Add comment to example app about optional shipping methods delegate #821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdorfman-stripe
approved these changes
Nov 3, 2017
There was a problem hiding this comment.
Cool.
Also though: I think we should consider changing the api so it is possible to both implement this and also conditionally not require shipping method? If people want to only sometimes require shipping method it might not be straightforward if it simply switches based on presence of a method since you can't change that at runtime. I'm not sure how real a use that is though.
|
Yeah, updating the API so that calling |
mludowise-stripe
pushed a commit
that referenced
this pull request
Mar 13, 2022
…nd color (#800) * Add PaymentSheetAppearance * Migrate background color to PaymentSheetAppearance * Try to fix namespace * Add TODO * Refactor primary color * Fix checkbox stroke color * Add comment * Fix tests * Default checkbox stroke to black * Update Stripe/PaymentSheetAppearance.swift Co-authored-by: Yuki <[email protected]> * Group appearance APIs, remove didSet as well * Make checkbox black stroke * Revert change on primaryButtonColor * Add TOOD comment * Re-record tests * Update check circle background to match appearance primary * 🎨 Text, secondary text, icon, danger, border, componentBackground colors (#821) * Refactor text color * primary and secondary text color refactor * refactor for icon color * dangerColor, componentBorderColor, componentBackgroundColor * Audit changes thus far * Refactor for componentDividerColor * Refactor corner radius * Border width refactor * Set corner radius on link button * Refactor for shadows * Revert "Refactor for componentDividerColor" This reverts commit 028ebfc60934ac58ae4b57251c7f0cb9a86de6da. * Revert form element changes * Revert sepa mandate change, update checkbox stroke * Little bit more clean up * Fix build issue * Fill checkbox with componentBackground * Set border on checkbox * Set checkbox label color * Fix shadow corner radius * Fix build issue * Update snapshots * update checkbox snapshot tests * comment out record * Don't modify link appearance * update link snapshot tests * update snapshots * PR feedback * Make link checkbox blue * update new snapshot tests :/ * Update snapshots from latest * Fix test * Record dark mode tests Co-authored-by: Yuki <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @bdorfman-stripe
Addresses some confusion in #818. This is currently documented in the header, but not clear in the example app.